Fix wrong type in storage variable #307
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change variable type of "encryption_key" from string to jsonarg as the underlying api throws an error when using an existing encryption key directly inside the variable as it becomes a string which the api doesnt like.
NonProgrammerCharacter
had a problem deploying
to
external
GitHub Actions
Failure
|
@lae any chance we can merge this PR? Currently the proxmox_storage.py library isn't parsing a JSON encryption_key properly. I tried multiple quoting/formating and none work properly. This change fixes JSON encryption_keys and keep the autogen option working too (tested both on my side without issue). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change variable type of "encryption_key" from string to jsonarg as the underlying api throws an error when using an existing encryption key directly inside the variable as it becomes a string which the api doesnt like.
I have the encryption key as a dict in my ansible vault.
Debug output before the fix:
DEBUG ENCRYPTION_KEY value: "{'kdf': None, 'created': '2022-09-07T08:46:13+02:00', 'modified': '2022-09-07T08:46:13+02:00', 'data': 'xxx', 'fingerprint': 'xxx'}"This is my debug output after the fix:
DEBUG ENCRYPTION_KEY value: {"kdf": null, "created": "2022-09-07T08:46:13+02:00", "modified": "2022-09-07T08:46:13+02:00", "data": "xxx", "fingerprint": "xxx"}And this was the error I got when running my playbook:
With this fix my storage configuration is using the encryption key from my ansible vault and can access our backups.